[RELEASE]THE FIRST NPC I'VE EVER CODED!

Quote:

Originally Posted by airborne. Yes I agree, but it is my first code lol wasn't supposed to be the best.

Lol don't worry, I wasn't flaming your code.
It's only your first.
Doesn't need to be great.
I was just giving feedback on 12tails' code.

Quote:

Originally Posted by Tiku In my opinion you should rather use 12tails' code than airborne. That's only because its short and takes up less room and is simpler.

I wouldnt, if someone decides that they are going to try and bring down your server, that code can be exploited by changing your job to something that isnt defined in the source, like 82, then everything which requires the server to determine the job of a character and make a decision based on it will almost certainly result in an exception, and crash the server.

And no one wants that do they?

Quote:

Originally Posted by Korvacs I wouldnt, if someone decides that they are going to try and bring down your server, that code can be exploited by changing your job to something that isnt defined in the source, like 82, then everything which requires the server to determine the job of a character and make a decision based on it will almost certainly result in an exception, and crash the server. And no one wants that do they?

And how would that be any different from using airborne's code?

Quote:

Originally Posted by Korvacs I wouldnt, if someone decides that they are going to try and bring down your server, that code can be exploited by changing your job to something that isnt defined in the source, like 82, then everything which requires the server to determine the job of a character and make a decision based on it will almost certainly result in an exception, and crash the server. And no one wants that do they?

How is it possible? My NPC only gives you choices of correct Job ids.

Quote:

Originally Posted by Tiku And how would that be any different from using airborne's code?

Airborne's lets people choose which class they are, and the server handles which job id they get.

With the other one, i could send a packet to the server with a control id of anything between 15 & 145, and the server would assign my job ID to the control id, meaning that you could get a job of 99 and that would be invalid.

So its completely different, Airbornes is safer in that respect.

Good Job.

Tiku: you could of said good job and let it be, but NO! you got to make it sound like its the end of the world.

Quote:

Originally Posted by arab4life Good Job. Tiku: you could of said good job and let it be, but NO! you got to make it sound like its the end of the world.

Quote:

Originally Posted by arab4life Good Job. Tiku: you could of said good job and let it be, but NO! you got to make it sound like its the end of the world.

Lol I told him good job over msn when he first showed me the code.

Quote:

Originally Posted by Korvacs Airborne's lets people choose which class they are, and the server handles which job id they get. With the other one, i could send a packet to the server with a control id of anything between 15 & 145, and the server would assign my job ID to the control id, meaning that you could get a job of 99 and that would be invalid. So its completely different, Airbornes is safer in that respect.

Someone who actually uses his brain.
Not only checking room and/or memory, but also safety and such.

Lol if u Copie some thing dont thell u made this ur self.. BECOS THIS A COPIE FROM 4 botters. , Pff

Quote:

Originally Posted by angeloraaf Lol if u Copie some thing dont thell u made this ur self.. BECOS THIS A COPIE FROM 4 botters. , Pff

no it's not i don't need to go into a stupid leacher's forum to steal something and call it mine. why would i lie, be quiet please, i made it myself with some examples.

Quote:

Originally Posted by angeloraaf Lol if u Copie some thing dont thell u made this ur self.. BECOS THIS A COPIE FROM 4 botters. , Pff

Atually the same person released it on both forums.

Nice job. Always nice to see people trying their hand at coding. Hopefully you will keep going with it. I'm sure before you know it you will be able to do alot more ^^

Quote:

Originally Posted by Korvacs Atually the same person released it on both forums.

lol i don't remember could've been i don't remember if i did.

Ehh I added this just.. I think there's missing that What you need to add in NPCS.txt .. Cause I checked mine and I didnt detect anywhere where was something like this 300002?

and whats the meaning of npcs anyway? o.O I mean all the numbers there.. example: 205 1086 16 0 1036 237 189 <-- is that 1086 like that case number in NPCDialog.cs ?