[Release] Free FFXIV Fishing bot. Works with 2.5.1

03/27/2015 03:47 LuckOnCooldown#16
Unfortunately, I'm an idiot and I didn't print the right thing in the error message. That actually doesn't help me at all. The version attached here is fixed. Please run it and let me know.

Thanks, and sorry.

EDIT: If you run into this error message, please let me know what bait and rod you're fishing with, and where you're fishing.
03/27/2015 05:11 tomhanks123#17
Quote:
Originally Posted by LuckOnCooldown View Post
Unfortunately, I'm an idiot and I didn't print the right thing in the error message. That actually doesn't help me at all. The version attached here is fixed. Please run it and let me know.

Thanks, and sorry.

EDIT: If you run into this error message, please let me know what bait and rod you're fishing with, and where you're fishing.
New error is :

[5:11:03] Bot Started!
[5:11:04] Casting fishing line!
[5:11:05] Unknown Fishing State [46] encountered

Using Supra rod with heavy steel jig.

It's the jigs that's messing with it. Just switched to live bait and it works fine.
03/27/2015 05:23 LuckOnCooldown#18
Quote:
Originally Posted by tomhanks123 View Post
New error is :

[5:11:03] Bot Started!
[5:11:04] Casting fishing line!
[5:11:05] Unknown Fishing State [46] encountered

Using Supra rod with heavy steel jig.

It's the jigs that's messing with it. Just switched to live bait and it works fine.
Fixed, and updated in the OP. Thanks for working with me. I was also able to infer some other fishing states that I was missing. Given what I know, there are probably still some missing. Please let me know if you find them!
03/27/2015 05:52 tomhanks123#19
Quote:
Originally Posted by LuckOnCooldown View Post
Fixed, and updated in the OP. Thanks for working with me. I was also able to infer some other fishing states that I was missing. Given what I know, there are probably still some missing. Please let me know if you find them!
Yup, working perfectly now. Thanks for the hard work! I'll update you if I notice any other problems.

Edit: I think the tmp.mp3 still isn't fixed at the moment. Deleted the folder and error popped up. Not a big issue though since the work around is simple.

Hmm a bit of fishing and I encountered this fishing error:

6:15:00] You got a bite!
[6:15:03] Unknown Fishing State [53] encountered
[6:15:03] Bot stopped!

Happened after I catch a Gigant Clam.

Also, I was testing around the weather and time settings and I don't think the time settings work, I'll get back to you on the weather.

Weather seems to work fine, update on the time setting, I think the time semi works but like many things I've owned, it doesn't seem to respond very well when the time is between midnight (i.e. 11 pm to 2 am).
03/27/2015 06:48 LuckOnCooldown#20
Quote:
Originally Posted by tomhanks123 View Post
Yup, working perfectly now. Thanks for the hard work! I'll update you if I notice any other problems.

Edit: I think the tmp.mp3 still isn't fixed at the moment. Deleted the folder and error popped up. Not a big issue though since the work around is simple.

Hmm a bit of fishing and I encountered this fishing error:

6:15:00] You got a bite!
[6:15:03] Unknown Fishing State [53] encountered
[6:15:03] Bot stopped!

Happened after I catch a Gigant Clam.

Also, I was testing around the weather and time settings and I don't think the time settings work, I'll get back to you on the weather.

Weather seems to work fine, update on the time setting, I think the time semi works but like many things I've owned, it doesn't seem to respond very well when the time is between midnight (i.e. 11 pm to 2 am).
You're right, I missed a spot where tried to delete c:\Temp\tmp.mp3, fixed. I added fishing state 53 as a Reeling state. I'll look into the time thing. It probably has to do with crossing midnight. That's always a pain in the ass. Thanks for the feedback.
03/27/2015 07:19 tomhanks123#21
more fishing states :)

[7:18:46] You got a bite!
[7:18:48] Unknown Fishing State [54] encountered
[7:18:48] Bot stopped!

I notice the program still hooks the fish even though it encounters the error before it stops, is it possible to make it so the bot keeps fishing after the error report. I understand that ideally we don't get the error but this way it can still be functional (perhaps something like 3 errors before a stop)? I think I may still have a few more fishing states to report, possibly the fish getting away or fish breaking the line etc.

Update: Haven't run into other errors besides the one additional one above stated. Some feedback on the hotbar parse, it seems to work fine the first time but once you change class, do something else, switch back, it seems to lose the ability to parse the hotbars. The bandaid for this is to log out (not closed the game), close and relaunch program and that seems to do the trick. Can get bit a inconvenient though.
03/27/2015 11:55 hman32#22
Quote:
Also, post a screenshot of your hotbars please.
I've tried different hotbar settings, but to no avail. Here's my initial settings, hotbars 4-8 are shared:
[Only registered and activated users can see links. Click Here To Register...]

Also, can you please show your hotbar settings, so I can check if they would work for me?

If parsing hotbars has so many issues, I agree it would be much more effective to just use fixed bindings like '1' for 'Cast', '2' for 'Hook', etc.

I haven't run the version by StolasZagan, but his description says that he uses this model of sending commands:
[Only registered and activated users can see links. Click Here To Register...]
Quote:
The bot is very simple to setup:
1. Be in Mouse/Keyboard mode.
2. Put your cast command on the 1 key.
3. Put your hook command on the 2 key.
4. (Optional) if you want to mooch, then put the mooch command on the 3 key.
5. Put your quit command on the 4 key.
Probably there were good reasons for this.
03/27/2015 15:33 LuckOnCooldown#23
Quote:
Originally Posted by tomhanks123 View Post
more fishing states :)

[7:18:46] You got a bite!
[7:18:48] Unknown Fishing State [54] encountered
[7:18:48] Bot stopped!

I notice the program still hooks the fish even though it encounters the error before it stops, is it possible to make it so the bot keeps fishing after the error report. I understand that ideally we don't get the error but this way it can still be functional (perhaps something like 3 errors before a stop)? I think I may still have a few more fishing states to report, possibly the fish getting away or fish breaking the line etc.

Update: Haven't run into other errors besides the one additional one above stated. Some feedback on the hotbar parse, it seems to work fine the first time but once you change class, do something else, switch back, it seems to lose the ability to parse the hotbars. The bandaid for this is to log out (not closed the game), close and relaunch program and that seems to do the trick. Can get bit a inconvenient though.
The fact that it hooked the fish first is important information. That means that the unknown state you encountered is a reeling state, as opposed to a casting or fishing state.

I ran into the problem with switching jobs and causing the hotbar parse to fail, but I fixed it, and it doesn't happen for me anymore. :( That's really irritating that it's still happening for you. I'll look into it tonight.

Btw, I fixed the issue with the timespan crossing midnight, I just haven't posted it yet, I wanted to test it a little more first. The code I had put in to handle it simply did not work the way MSDN said it does. I had to find a workaround.

Quote:
Originally Posted by hman32 View Post
I've tried different hotbar settings, but to no avail. Here's my initial settings, hotbars 4-8 are shared:
[Only registered and activated users can see links. Click Here To Register...]

Also, can you please show your hotbar settings, so I can check if they would work for me?

If parsing hotbars has so many issues, I agree it would be much more effective to just use fixed bindings like '1' for 'Cast', '2' for 'Hook', etc.

I haven't run the version by StolasZagan, but his description says that he uses this model of sending commands:
[Only registered and activated users can see links. Click Here To Register...]


Probably there were good reasons for this.
I will post a pic of my hotbar settings tonight. And yeah, parsing hotbars is finicky. Maybe I'll add an option to use set keys. I'll keep looking into your issues. Do you think you could also post a pic of your actual hotbar settings window? I'll try to duplicate your setup exactly and see if I can get it to fail.

Edit: Oh shit...I just looked at your picture again, and I know exactly what your problem is. I'm not handling the case where the hotkey is a letter. This is causing one of your buttons to be in a "not found" state. This is a REALLY easy fix too. I'll knock it out when I get home from work.

Edit: Actually, it was so easy I decided to just go ahead and do it. v0.9.5 is posted in the OP. It works for me now when letters are assigned to hotkeys. It definitely broke with "Unable to parse" before. Let me know how it works for you.

Edit: Hmm, that may or may not have been the issue in your case HMan. The more I look at it, the more I think that the hotbar parsing code wouldn't have failed, but the bot just wouldn't have been able to use Release. Try it out anyway, just in case, and let me know the results. If the current fix doesn't work, I'll just add some code to dump the memory where it thinks hotbars are on your machine and have you send me the resulting file. I should be able to figure out what's going wrong from there.
03/27/2015 18:59 hman32#24
It works! Looks like the problem was in letters indeed :) I'm going to test it on various locations later. Thanks again!
03/27/2015 19:27 Zorosenpai#25
Yesssss it works! THANK YOU LuckOnCooldown! Keep updating it! :handsdown:
03/27/2015 19:45 jjolin#26
I am not running cross hotbars, but it still says error parsing hotbars. Even diabling all hotbars except the basic three rows, still get the parsing error.


EDIT: restarted the game, and now it works. huh.
03/27/2015 20:12 onupees#27
unable to parse hotbars !
03/27/2015 20:43 xphacter#28
I havent had a chance to look through your code yet, however I am getting the unable to parse hotbars issue again, even without cross hotbars.

Maybe have an option, if unable to parse hotbars, make it default to work like the old program, and 1 2 3 4
03/27/2015 20:45 LuckOnCooldown#29
Quote:
Originally Posted by jjolin View Post
I am not running cross hotbars, but it still says error parsing hotbars. Even diabling all hotbars except the basic three rows, still get the parsing error.


EDIT: restarted the game, and now it works. huh.
This is a known bug. For some people, when they switch jobs it looses the ability to parse hotbars.

The only work around currently is to switch to FSH, and log out, and back in.

I had this problem once before, and I fixed it, and now I can't reproduce it anymore, so I'm going to have to work with someone who can reproduce it consistently to try to fix it.

Quote:
Originally Posted by onupees View Post
unable to parse hotbars !
Try the above workaround please!
03/27/2015 20:47 Kynian#30
[4:44:03] Casting fishing line!
[4:44:03] Expected status 'Casting' or 'Fishing', but got: 'Not Fishing'
[4:44:03] Bot stopped

That's when i try to use it. I press the start button and the "2" key on my hotbar flashes. My "2" key is set to Hook, so it never casts.

So I tried to put my Cast command on my 2 and pressed start, and it worked. Until something actually got hooked. The bot then attempted to use my "2" key again and the fish got away.

Before i was having the "Unable to parse hotbars" problem. I restarted the game and that seemed to solve it. I have no idea how to solve this "using same key command" problem though, and I'm no programmer.

If it helps at all, I play on steam, and my game isnt installed on C at all, it's on a completely different partition, F:\

Help me out please.