I had to change the code quite a bit to get this to work. For example, the main loop now looks like this:
; Main loop
While 1
; Pick up stuff in case there are some other errors we didn't detect
Loot()
; Check to see if HUD is turned on
$hud = _ImageSearchArea("hud.BMP",0,$tl_x,$tl_y,$br_x,$br _y,$x,$y,80)
; Makes SURE we close HUD
While ($hud=1)
Send("{\ 1}")
Sleep(200)
$hud = _ImageSearchArea("hud.BMP",0,$x,$y,$br_x,$br_y,$x, $y,80)
WEnd
; Pauses script if Mabi window exits
CheckPause()
; Load Metallurgy skill
Send("{F1 5}")
Sleep(1500)
; Pauses script if Mabi window exits
CheckPause()
; Pick up stuff in case there are some other errors we didn't detect
Loot()
; Click our stored value of next target ore site
MouseMove($site_x,$site_y,0)
MouseClick("left",$site_x,$site_y,5,0) ; Click 3 times for funz!
Sleep(10000)
ResetMouse()
; Pauses script if Mabi window exits
CheckPause()
; Pick up stuff in case there are some other errors we didn't detect
Loot()
; While skill is working, search for next ore site :D YAY EFFICIENCY
SearchSite(1)
; Might have a 1 sec delay between last small skill flashing part to finish
Sleep(500)
WEnd
It's probably slower then the OP, but I could not get the skill to recognize between loading and loaded no matter how many screen shots i took or how I sized them.
I also added a sleep in the sitesearch function to give me a chance to move around a bit. It actually helps.
Finally, you will need new screenshots... lots of them. LOTS OF THEM! Aparently they changed the shading affect so you will need to watch it for a while and if you see you're standing next to a patch and it's not recognizing, take a SS while ALT is down, then crop the heck out of it. Save your new BMP as silver2, silver3... etc.
Just add a new search line to the sitesearch function with your BMP's name. Presto!
Like I said, it's slower, but not that much slower than I am normally, plus it doesn't miss anything now. And it only took about 3 hours to flood my inventory.